[vlc-devel] [PATCH 0/2] Work around/fix network issues on Android

Hugo Beauzée-Luyssen hugo at beauzee.fr
Fri Mar 29 11:35:15 CET 2019


This small patchset aims at fixing recent regressions on Android where:
- Some ArmV8 devices are returning invalid sendmsg error results
- Some ArmV7 devices fail to use TCP_FASTOPEN and return an unexpected

The sendmsg patch is ugly and I'm very open to alternatives, but as far as I
can see, the issue is in older devices kernel, and there's not much we
can do but doing our best to work around it.
I believe the MSG_FASTOPEN patch to be correct, even though one could
argue that MSG_FASTOPEN shouldn't be defined in the first place if the 
kernel doesn't support this feature. While I agree, we have to work with
what the Android NDK provides us with.

Hugo Beauzée-Luyssen (2):
  compat: Workaround sendmsg bug on some ArmV8 Android devices
  network: tls: Handle errors from older kernels

 compat/sendmsg.c      | 24 ++++++++++++++++++++++++
 configure.ac          |  3 +++
 include/vlc_network.h |  6 ++++++
 src/network/stream.c  |  6 +++++-
 4 files changed, 38 insertions(+), 1 deletion(-)


More information about the vlc-devel mailing list