[vlc-devel] [RFC v2 4/8] libvlc: handle the input colorimetry on the surface callbacks

Rémi Denis-Courmont remi at remlab.net
Thu May 2 16:33:20 CEST 2019


Le torstaina 2. toukokuuta 2019, 16.28.47 EEST Steve Lhomme a écrit :
> ---
>  include/vlc/libvlc_media_player.h | 53 ++++++++++++++++++++++++++++++-
>  include/vlc_vout_display.h        |  8 +++++
>  lib/media_player.c                | 37 ++++++++++++++++++++-
>  3 files changed, 96 insertions(+), 2 deletions(-)

Colorimetry is, or should be, part of the track meta data, where it can be 
accessed regardless of rendering mechanism, regardless of track selection, and 
can be extended without breaking apps.

The video output already is supposed to have the shaders for colours inside 
OGL / DX outputs. I don't see why the rendering callbacks should care. 
Besides, that will break as soon as a new enum member needs to be added, and 
the app does not know it.

-- 
Реми Дёни-Курмон
http://www.remlab.net/





More information about the vlc-devel mailing list