[vlc-devel] [PATCH] win32/build.sh: quote PATH/PKG_CONFIG_LIBDIR

Alexandre Janniaux ajanni at videolabs.io
Fri May 3 17:08:00 CEST 2019


Not quoting results in potential errors when building in WSL, where
spaces in $PATH or $PWD can be quite common.
---
 extras/package/win32/build.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/extras/package/win32/build.sh b/extras/package/win32/build.sh
index 584145abb1..ece1a3b821 100755
--- a/extras/package/win32/build.sh
+++ b/extras/package/win32/build.sh
@@ -99,12 +99,12 @@ if [ "$INTERACTIVE" != "yes" ] || [ ! -f ./Makefile ]; then
     ./bootstrap
 fi
 make -j$JOBS
-export PATH=$PWD/build/bin:$PATH
+export PATH="$PWD/build/bin:$PATH"
 cd ../../

 export USE_FFMPEG=1
-export PKG_CONFIG_LIBDIR=$PWD/contrib/$TRIPLET/lib/pkgconfig
-export PATH=$PWD/contrib/$TRIPLET/bin:$PATH
+export PKG_CONFIG_LIBDIR="$PWD/contrib/$TRIPLET/lib/pkgconfig"
+export PATH="$PWD/contrib/$TRIPLET/bin:$PATH"

 if [ "$INTERACTIVE" = "yes" ]; then
 if [ "x$SHELL" != "x" ]; then
--
2.21.0


More information about the vlc-devel mailing list