[vlc-devel] [PATCH 01/10] Enable secondary SPU ES and selection from the GUI

[Jean-Baptiste Kempf]

On Sun, 5 May 2019, at 12:17, Roland Bewick wrote:
> This set of patches is regarding the feedback I received from my initial 
> patch to support dual subtitles in VLC.

As dual-subtitle is one of the two most asked features, thank you very much.

> I've changed how the secondary SPU ES is selected and how the alignment 
> is set without having to touch individual decoders.
> 
> I've added configuration for the secondary subtitles (enable, alignment 
> and margin). Dual subtitles are disabled by default.

I don't think this needs a configuration option. If the spu selected has 2 values, both are activated.
This is related to VLC_VAR_HASCHOICE or something.

> I added a new hotkey (toggle) which allows you to use the existing 
> subtitle controls to control the secondary subtitles.
> 
> I also adjusted the QT GUI synchronization to allow users to set the 
> secondary subtitle delay from the GUI.
> 
> Unfortunately I don't have access to a mac, but hopefully the hotkeys 
> should suffice until the mac GUI can also be updated.
> 
> If you have any questions or suggestions, please let me know.

Just my thanks. This is really cool.

-- 
Jean-Baptiste Kempf -  President
+33 672 704 734