[vlc-devel] [PATCH 00/20] MR: Finishing vout life cycle work

[Thomas Guillem]

I updated the vout-life/6 branch : https://code.videolan.org/tguillem/vlc/commits/vout-life/6

- Big changes in "resource: create first vout from HoldVout*()" and "player: create vout when requested"

 Indeed, you want to create a vout by default, but only when calling vlc_player_HoldVout*(). So all internal code that hold vouts won't create one by default.


 - "How is the race fixed ?"

I don't really know. There were huge changes in the UI/player/resource/vout, I don't see any signs of possible deadlocks anymore. I tested this branch with ASAN/TSAN, with and without Pierre 's OpenGL integration pacthes, with media having multiple vouts.

On Tue, May 7, 2019, at 14:26, Thomas Guillem wrote:
> Now that I'm able to run Qt with TSAN: https://code.videolan.org/tguillem/vlc/commits/tsan 
> It's not fixed.
> 
> On Tue, May 7, 2019, at 14:20, Rémi Denis-Courmont wrote:
>> Hi,
>> 
>> I don't see how it's any less needed now than before. How is the race fixed??
>> 
>> Le 7 mai 2019 14:00:54 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>>> 
>>> On Tue, May 7, 2019, at 12:15, Rémi Denis-Courmont wrote:
>>>> That's only true if vout are requested sequentially, which they basically never are since video decoders always run in their own thread.
>>> 
>>> What is only true ? "Restoring a failing vout atomically is not needed anymore" ?
>>> 
>>>> -- 
>>>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
>>>> _______________________________________________
>>>> vlc-devel mailing list
>>>> To unsubscribe or modify your subscription options:
>>>> https://mailman.videolan.org/listinfo/vlc-devel
>>> 
>> 
>> -- 
>> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190507/ebbb83e5/attachment.html>