[vlc-devel] [PATCH 00/20] MR: Finishing vout life cycle work

[Rémi Denis-Courmont]

I'm not sure it's okay to propose patches with the same known bug four times in a row, make the reviewer repeat the problem twice as many, and then imply that the reviewer may be misbehaving.

Le 8 mai 2019 10:04:52 GMT+03:00, Thomas Guillem <thomas at gllm.fr> a écrit :
>
>
>On Tue, May 7, 2019, at 20:50, Rémi Denis-Courmont wrote:
>> Le tiistaina 7. toukokuuta 2019, 19.11.43 EEST Thomas Guillem a écrit
>:
>> > I updated the vout-life/6 branch :
>> > https://code.videolan.org/tguillem/vlc/commits/vout-life/6
>> > 
>> > - Big changes in "resource: create first vout from HoldVout*()" and
>"player:
>> > create vout when requested"
>> > 
>> >  Indeed, you want to create a vout by default, but only when
>calling
>> > vlc_player_HoldVout*(). So all internal code that hold vouts won't
>create
>> > one by default.
>> > 
>> > 
>> >  - "How is the race fixed ?"
>> > 
>> > I don't really know.
>> 
>> If you don't know which of the locking orders you got rid of, then
>it's pretty 
>> safe to assume that it's none of them and the two locks cannot be
>merged.
>
>I'll try to find it by debuging vlc 3.0
>But I'm not sure it's OK to refuse a patch because there might be a bug
>somewhere. 
>
>> 
>> -- 
>> レミ・デニ-クールモン
>> http://www.remlab.net/
>> 
>> 
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190508/78bea091/attachment.html>