[vlc-devel] [PATCH 0/5] Implement libvlc player using vlc_player

Thomas Guillem thomas at gllm.fr
Thu May 9 18:17:26 CEST 2019


On Thu, May 9, 2019, at 17:57, Romain Vimont wrote:
> The purpose is to remove input_thread_t usage in libvlc. This paves the way
> to "privatize" input_thread_t in the core.
> 
> The libvlc API is kept (mostly) unchanged. A new API (matching the core player
> API) would be great, but it's not for now.
> 
> Here are the changes for libvlc users:
>  - the snapshot API is removed (patch 2)
>  - the "preparsed" event is not triggered anymore, it is now managed by the
>    playlist (or media tree) in the core (patch 3)
>  - libvlc_media_player_will_play() is deprecated and always returns true, it is
>    meaningless on the new player (patch 4)
> 
> I compiled vlc-android with this new libvlc implementation. What I tested
> worked without any code change: I can play, pause, resume, seek, change audio
> and subtitles track, change audio and subtitles delay...
> 
> Romain Vimont (5):
>   player: add on_device_changed callback
>   libvlc: player: remove snapshot API
>   libvlc: player: remove preparsed event
>   libvlc: player: deprecate will_play()
>   libvlc: player: use vlc_player

I think we are missing the most important one. Long commit is long, I guess it's waiting for mail review.

> 
>  include/vlc/libvlc_media_player.h |    1 +
>  include/vlc_player.h              |    9 +
>  lib/audio.c                       |   95 +-
>  lib/media_player.c                | 1580 ++++++++++++-----------------
>  lib/media_player_internal.h       |   21 +-
>  lib/video.c                       |  266 ++---
>  src/input/player.c                |    8 +
>  7 files changed, 772 insertions(+), 1208 deletions(-)
> 
> -- 
> 2.20.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list