[vlc-devel] [PATCH 5/5] libvlc: player: use vlc_player

[Rémi Denis-Courmont]

Le torstaina 9. toukokuuta 2019, 19.51.09 EEST Thomas Guillem a écrit :
> > Application should (still) be allowed to call this, and most* other
> > functions further down the patch, from within event callbacks. But this
> > leads to deadlock or abort depending on build type.
> > 
> > * Exceptions exist such _stop(), which would necessarily deadlock.
> 
> Not anymore, stop is asynchronous.

There should be a separate asynchronous stop (request) function, notably so 
that stop can be requested from within callbacks. And in hindsight, we 
probably should have done it that way from the beginning. But we did not have 
the benefit of hindsight and we specified stop to wait instead.

We cannot change it now, because we don't _silently_ break APIs. This would 
cause huge a number of use-after-free bugs in existing apps.

If you change the semantics, change the name and/or the number of parameters 
so that it won't fail silently.

-- 
Rémi Denis-Courmont
http://www.remlab.net/