[vlc-devel] [PATCH 03/18] text: vlc_strfinput: don't use input API

Thomas Guillem thomas at gllm.fr
Fri May 10 16:03:07 CEST 2019


This function is always called with a NULL input for now.
---
 src/text/strings.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/text/strings.c b/src/text/strings.c
index a2761f0c90..09a4d5c523 100644
--- a/src/text/strings.c
+++ b/src/text/strings.c
@@ -529,6 +529,7 @@ static int write_meta(struct vlc_memstream *stream, input_item_t *item,
     return 0;
 }
 
+/* FIXME: replace input_thread_t by vlc_player_t */
 char *vlc_strfinput(input_thread_t *input, input_item_t *item, const char *s)
 {
     struct vlc_memstream stream[1];
@@ -759,12 +760,14 @@ char *vlc_strfinput(input_thread_t *input, input_item_t *item, const char *s)
 
                 if (input != NULL)
                 {
+#if 0 /* cf. FIXME */
                     audio_output_t *aout = input_GetAout(input);
                     if (aout != NULL)
                     {
                         vol = aout_VolumeGet(aout);
                         aout_Release(aout);
                     }
+#endif
                 }
                 if (vol >= 0.f)
                     vlc_memstream_printf(stream, "%ld", lroundf(vol * 256.f));
-- 
2.20.1



More information about the vlc-devel mailing list