[vlc-devel] [PATCH 01/14] Enable secondary SPU ES and selection from the GUI

[Jean-Baptiste Kempf]

On Sat, 11 May 2019, at 13:15, Roland Bewick wrote:
> On Sat, 11 May 2019 at 4:17 PM, Rémi Denis-Courmont <remi at remlab.net> wrote:
>> Hi,
>> 
>> While it likely makes sense at the level of UI widgets and user interactions, it seems a bit out of place, standing alone, at the player API level.
>> 
>> In particular, I doubt that enabling multiple tracks mode in Qt should interfere with the track selection of, say, the HTTP remote control.
>> 
>> IMO, the API should just take the list of active tracks, whether it be empty, a singleton, or larger.
> 
> Hi, Remi,
> 
> I designed the changes so that none of the current consumers of the API will be impacted.
> 
> Enabling dual subtitles will not affect the others (like the remote control or lua scripts), because there is another requirement: to temporarily enable multitrack selection using the new call I added. The UI and hotkeys use this but none of the others do.
> 
> I do agree however that your suggestion is more fitting (but require a bit more logic from each consumer that supports selecting multiple tracks)

Make the API simple to maintain, for the core. UI will adapt.

--
Jean-Baptiste Kempf - President
+33 672 704 734


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190511/4bda2643/attachment.html>