[vlc-devel] [PATCH 01/14] Enable secondary SPU ES and selection from the GUI

[Rémi Denis-Courmont]

Hi,

I don't think we should consume another two hotkey letters for such fringe feature. On top of that, this feature is meant for multiple people to watch at the same time. It's somewhat unlikely that they'd be in front of the keyboard.

IMO, we should come to terms with the fact that VLC is a media player, not a video game. The whole custom hotkey thing is just weird, and causes problems with internationalisation and media keys.

Le 13 mai 2019 11:46:00 GMT+03:00, Roland Bewick <roland.bewick at gmail.com> a écrit :
>On Mon, 13 May 2019 at 2:49 PM, Thomas Guillem <thomas at gllm.fr> wrote:
>
>>
>>
>> On Sat, May 11, 2019, at 15:56, Roland Bewick wrote:
>>
>>
>> On 11/05/2019 6:21 PM, Jean-Baptiste Kempf wrote:
>>
>>
>>
>> On Sat, 11 May 2019, at 13:15, Roland Bewick wrote:
>>
>> On Sat, 11 May 2019 at 4:17 PM, Rémi Denis-Courmont <remi at remlab.net>
>> wrote:
>>
>> Hi,
>>
>> While it likely makes sense at the level of UI widgets and user
>> interactions, it seems a bit out of place, standing alone, at the
>player
>> API level.
>>
>> In particular, I doubt that enabling multiple tracks mode in Qt
>should
>> interfere with the track selection of, say, the HTTP remote control.
>>
>> IMO, the API should just take the list of active tracks, whether it
>be
>> empty, a singleton, or larger.
>>
>>
>> Hi, Remi,
>>
>> I designed the changes so that none of the current consumers of the
>API
>> will be impacted.
>>
>> Enabling dual subtitles will not affect the others (like the remote
>> control or lua scripts), because there is another requirement: to
>> temporarily enable multitrack selection using the new call I added.
>The UI
>> and hotkeys use this but none of the others do.
>>
>> I do agree however that your suggestion is more fitting (but require
>a bit
>> more logic from each consumer that supports selecting multiple
>tracks)
>>
>>
>> Make the API simple to maintain, for the core. UI will adapt.
>>
>> --
>> Jean-Baptiste Kempf -  President
>> +33 672 704 734
>>
>>
>>
>>
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription
>options:https://mailman.videolan.org/listinfo/vlc-devel
>>
>> Unfortunately it isn't just the SelectTrack function, but
>SelectNextTrack
>> and SelectPrevTrack too.
>>
>> I feel like making the consumer pass a list of already selected
>tracks
>> *plus* the new track to select is not right.
>>
>> I agree the api should be simple but it should also be simple to use.
>Will
>> this change make the core less complex?
>>
>> What I've done isn't so good, yes. But I don't think Rémi's idea is
>right
>> either. We're basically searching for tracks and then excluding the
>> selected ones so that they don't get selected again.
>>
>> Potential alternative option:
>> - Pass an extra parameter into the existing SelectTrack function -
>> selection type (Single / multiple).
>> - For SelectNextTrack/SelectPrevTrack functions I would need to pass
>the
>> "spu id" (1=primary, 2=secondary, 3=tertiary sub track)
>>
>>
>> Next/Prev should be disabled if there are multpiple tracks selected.
>> Indeed, this function is mostly used from a keyboard shortcut and
>there is
>> no way to circle next/prev for a specified id from a keyboard.
>>
>
>See my addition to cycling the secondary subtitle track using the
>keyboard.
>
>The secondary sub track can be controlled in the same way as the
>primary
>one using the new hotkey I added.
>
>Roland

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190513/d3f263e0/attachment.html>