[vlc-devel] [PATCH] audio_output: increase allowed max sample rate to 384 kHz

[Tristan Matthews]

On Wed, May 15, 2019 at 1:08 PM Rémi Denis-Courmont <remi at remlab.net> wrote:
>
> Le keskiviikkona 15. toukokuuta 2019, 19.01.10 EEST Tristan Matthews a écrit :
> > Fixes #21925
> > ---
> >  src/audio_output/dec.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/audio_output/dec.c b/src/audio_output/dec.c
> > index 91f9ccf2fe..e0c9f32b7e 100644
> > --- a/src/audio_output/dec.c
> > +++ b/src/audio_output/dec.c
> > @@ -72,7 +72,7 @@ int aout_DecNew(audio_output_t *p_aout, const
> > audio_sample_format_t *p_format, }
> >      }
> >
> > -    if( p_format->i_rate > 352800 )
> > +    if( p_format->i_rate > 384000 )
> >      {
> >          msg_Err( p_aout, "excessive audio sample frequency (%u)",
> >                   p_format->i_rate );
>
> Looks OK, but anybody remembers where the existing limit comes from?

Yup:

commit c8f94cd8514978513e18197c2c5ee4ccbc478226
Author: Rémi Denis-Courmont <remi at remlab.net>
Date:   Mon Aug 5 18:58:26 2013 +0300

    aout: allow frequency up to 352.8 kHz

    This is the frequency for SACD Digital eXtreme Definition.

    Higher sample rates exist, notably DSD's 2822.4kH but that is not PCM
    and the bitrate computation would really risk 31-bits integer overflow.