[vlc-devel] [vlc-commits] filter: remove unused SPU mouse callback

[Steve Lhomme]

On 2019-05-15 19:36, Rémi Denis-Courmont wrote:
> vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed May 15 20:24:14 2019 +0300| [a2b9bf8798509b4ca92c775a7f6c9cf127e29d99] | committer: Rémi Denis-Courmont
> 
> filter: remove unused SPU mouse callback
> 
>> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a2b9bf8798509b4ca92c775a7f6c9cf127e29d99
> ---
> 
>   include/vlc_filter.h    |  3 ---
>   src/misc/filter_chain.c | 13 -------------
>   2 files changed, 16 deletions(-)
> 
> diff --git a/include/vlc_filter.h b/include/vlc_filter.h
> index 65d2ea0e9f..57b7d4c799 100644
> --- a/include/vlc_filter.h
> +++ b/include/vlc_filter.h
> @@ -139,9 +139,6 @@ struct filter_t
>           int (*pf_video_mouse)( filter_t *, struct vlc_mouse_t *,
>                                  const struct vlc_mouse_t *p_old,
>                                  const struct vlc_mouse_t *p_new );
> -        int (*pf_sub_mouse)( filter_t *, const struct vlc_mouse_t *p_old,
> -                             const struct vlc_mouse_t *p_new,
> -                             const video_format_t * );
>       };

We may remove the union it was in as well. There's only pf_video_mouse 
inside now.

>       /* Input attachments
> diff --git a/src/misc/filter_chain.c b/src/misc/filter_chain.c
> index ffb5ba4d4e..9f9b739fb0 100644
> --- a/src/misc/filter_chain.c
> +++ b/src/misc/filter_chain.c
> @@ -505,19 +505,6 @@ int filter_chain_MouseEvent( filter_chain_t *p_chain,
>                                const vlc_mouse_t *p_mouse,
>                                const video_format_t *p_fmt )
>   {
> -    for( chained_filter_t *f = p_chain->first; f != NULL; f = f->next )
> -    {
> -        filter_t *p_filter = &f->filter;
> -
> -        if( p_filter->pf_sub_mouse )
> -        {
> -            vlc_mouse_t old = *f->mouse;
> -            *f->mouse = *p_mouse;
> -            if( p_filter->pf_sub_mouse( p_filter, &old, p_mouse, p_fmt ) )
> -                return VLC_EGENERIC;
> -        }
> -    }
> -
>       return VLC_SUCCESS;
>   }
>   
> 
> _______________________________________________
> vlc-commits mailing list
> vlc-commits at videolan.org
> https://mailman.videolan.org/listinfo/vlc-commits
>