[vlc-devel] [PATCH 4/5] configure: add an option to generate PDB files when building

[Martin Storsjö]

On Thu, 16 May 2019, Steve Lhomme wrote:

> This will only be enabled when building windows targets and will only work when
> compiling with Clang.
> ---
> bin/Makefile.am    |  4 ++++
> compat/Makefile.am |  3 +++
> configure.ac       | 13 +++++++++++++
> lib/Makefile.am    |  4 ++++
> modules/common.am  |  3 +++
> src/Makefile.am    |  4 ++++
> 6 files changed, 31 insertions(+)
>
> diff --git a/bin/Makefile.am b/bin/Makefile.am
> index 0bfa668806..d3e9144efe 100644
> --- a/bin/Makefile.am
> +++ b/bin/Makefile.am
> @@ -25,6 +25,7 @@ endif
> #
> vlc_LDADD = ../lib/libvlc.la
> vlc_CPPFLAGS = $(AM_CPPFLAGS)
> +vlc_CFLAGS = $(AM_CFLAGS)
> if !HAVE_WIN32
> vlc_SOURCES = vlc.c override.c
> vlc_LDADD += $(LIBDL)
> @@ -32,6 +33,9 @@ else
> vlc_SOURCES = winvlc.c
> vlc_DEPENDENCIES = vlc_win32_rc.$(OBJEXT)
> vlc_LDFLAGS = -mwindows -Wc,-static
> +if HAVE_PDB
> +vlc_LDFLAGS += -Wl,-pdb,vlc.pdb
> +endif
> vlc_LDADD += vlc_win32_rc.$(OBJEXT)
> libbreakpad_wrapper_la_SOURCES = breakpad.cpp
> libbreakpad_wrapper_la_LIBADD = $(BREAKPAD_LIBS)
> diff --git a/compat/Makefile.am b/compat/Makefile.am
> index d709d565c5..785721c0aa 100644
> --- a/compat/Makefile.am
> +++ b/compat/Makefile.am
> @@ -2,6 +2,9 @@ pkglib_LTLIBRARIES = libcompat.la
> libcompat_la_SOURCES = dummy.c
> libcompat_la_LIBADD = $(LTLIBOBJS) $(LIBRT) $(LIBM)
> libcompat_la_LDFLAGS = -no-undefined -static
> +if HAVE_PDB
> +libcompat_la_LDFLAGS += -Wl,-pdb,libcompat.pdb
> +endif

This bit is a little unnecessary here, as libcompat isn't built as a DLL.

// Martin