[vlc-devel] [vlc-commits] Remove libvlc_free

[Thomas Guillem]

I would like that you revert this patch.
Then, you can propose it on the ML and we can discuss about it. The MR way, that we almost all decided to do... 

On Mon, May 20, 2019, at 08:33, Thomas Guillem wrote:
> And more importantly, where is the patch?  Such commits should go first 
> on the ML. 
> 
> On Mon, May 20, 2019, at 08:16, Steve Lhomme wrote:
> > On 2019-05-19 13:26, Rémi Denis-Courmont wrote:
> > > vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Feb 13 19:03:48 2010 +0200| [fa0d74966e6338fc66b3b59120c2923b7fd6ae5f] | committer: Rémi Denis-Courmont
> > > 
> > > Remove libvlc_free
> > 
> > That means libvlc users in other languages have to make a call to the C 
> > runtime by themselves ? Right now it was possible to just take the 
> > libvlc DLL and never have to deal with C at all.
> > 
> > > (cherry picked from commit 61f0547b72d3ba80039f09064249d89fa8f2b0f7)
> > 
> > What branch is this cherry picked from ?
> > 
> > > 
> > >> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=fa0d74966e6338fc66b3b59120c2923b7fd6ae5f
> > > ---
> > > 
> > >   include/vlc/libvlc.h              | 9 ---------
> > >   include/vlc/libvlc_media_player.h | 2 +-
> > >   lib/core.c                        | 5 -----
> > >   lib/libvlc.sym                    | 1 -
> > >   4 files changed, 1 insertion(+), 16 deletions(-)
> > > 
> > > diff --git a/include/vlc/libvlc.h b/include/vlc/libvlc.h
> > > index 1c2550fe3b..0ec0045c96 100644
> > > --- a/include/vlc/libvlc.h
> > > +++ b/include/vlc/libvlc.h
> > > @@ -277,15 +277,6 @@ LIBVLC_API const char * libvlc_get_compiler(void);
> > >    */
> > >   LIBVLC_API const char * libvlc_get_changeset(void);
> > >   
> > > -/**
> > > - * Frees an heap allocation returned by a LibVLC function.
> > > - * If you know you're using the same underlying C run-time as the LibVLC
> > > - * implementation, then you can call ANSI C free() directly instead.
> > > - *
> > > - * \param ptr the pointer
> > > - */
> > > -LIBVLC_API void libvlc_free( void *ptr );
> > > -
> > >   /** \defgroup libvlc_event LibVLC asynchronous events
> > >    * LibVLC emits asynchronous events.
> > >    *
> > > diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
> > > index cf432a7352..7b96fbd76c 100644
> > > --- a/include/vlc/libvlc_media_player.h
> > > +++ b/include/vlc/libvlc_media_player.h
> > > @@ -1497,7 +1497,7 @@ LIBVLC_API void libvlc_video_set_scale( libvlc_media_player_t *p_mi, float f_fac
> > >    *
> > >    * \param p_mi the media player
> > >    * \return the video aspect ratio or NULL if unspecified
> > > - * (the result must be released with free() or libvlc_free()).
> > > + * (the result must be released with free()).
> > >    */
> > >   LIBVLC_API char *libvlc_video_get_aspect_ratio( libvlc_media_player_t *p_mi );
> > >   
> > > diff --git a/lib/core.c b/lib/core.c
> > > index 06fd52fbfa..6edf14b154 100644
> > > --- a/lib/core.c
> > > +++ b/lib/core.c
> > > @@ -151,11 +151,6 @@ const char * libvlc_get_changeset(void)
> > >       return psz_vlc_changeset;
> > >   }
> > >   
> > > -void libvlc_free( void *ptr )
> > > -{
> > > -    free( ptr );
> > > -}
> > > -
> > >   static libvlc_module_description_t *module_description_list_get(
> > >                   libvlc_instance_t *p_instance, const char *capability )
> > >   {
> > > diff --git a/lib/libvlc.sym b/lib/libvlc.sym
> > > index 51a45688de..456f9c22e3 100644
> > > --- a/lib/libvlc.sym
> > > +++ b/lib/libvlc.sym
> > > @@ -49,7 +49,6 @@ libvlc_dialog_set_callbacks
> > >   libvlc_dialog_set_context
> > >   libvlc_event_attach
> > >   libvlc_event_detach
> > > -libvlc_free
> > >   libvlc_get_changeset
> > >   libvlc_get_compiler
> > >   libvlc_get_fullscreen
> > > 
> > > _______________________________________________
> > > vlc-commits mailing list
> > > vlc-commits at videolan.org
> > > https://mailman.videolan.org/listinfo/vlc-commits
> > > 
> > _______________________________________________
> > vlc-devel mailing list
> > To unsubscribe or modify your subscription options:
> > https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel