[vlc-devel] [PATCH 0/2] Libvlc formatted log callback

Romain Vimont rom1v at videolabs.io
Mon May 20 14:33:57 CEST 2019


On Mon, May 20, 2019 at 02:18:11PM +0200, Steve Lhomme wrote:
> On 2019-05-20 14:03, RĂ©mi Denis-Courmont wrote:
> > I don't see how passing va_list to whatever is the appropriate
> > formatting function for your logging system, is a PITA.
> 
> The order or the elements in the va_list is completely arbitrary and
> entirely depends on the format string it's tied to. There's no way the
> libvlc host can actually make sense of which parameter does what and
> reformat this.
> 
> IMO we can just replace this by the formatted string and everyone will be
> happy. Nothing will be lost.

+1

The va_list in the interface just leaks an implementation detail.


More information about the vlc-devel mailing list