[vlc-devel] [PATCH v3 5/8] libvlc: player: remove will_play()

Romain Vimont rom1v at videolabs.io
Mon May 20 17:35:14 CEST 2019


This function is meaningless on the new player.
---
 include/vlc/libvlc_media_player.h |  8 --------
 lib/libvlc.sym                    |  1 -
 lib/media_player.c                | 13 -------------
 3 files changed, 22 deletions(-)

diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
index 0df3c0bcc7..27f34ab239 100644
--- a/include/vlc/libvlc_media_player.h
+++ b/include/vlc/libvlc_media_player.h
@@ -1176,14 +1176,6 @@ LIBVLC_API int libvlc_media_player_get_chapter( libvlc_media_player_t *p_mi );
  */
 LIBVLC_API int libvlc_media_player_get_chapter_count( libvlc_media_player_t *p_mi );
 
-/**
- * Is the player able to play
- *
- * \param p_mi the Media Player
- * \retval boolean
- */
-LIBVLC_API int libvlc_media_player_will_play( libvlc_media_player_t *p_mi );
-
 /**
  * Get title chapter count
  *
diff --git a/lib/libvlc.sym b/lib/libvlc.sym
index 456f9c22e3..ca115fb7b1 100644
--- a/lib/libvlc.sym
+++ b/lib/libvlc.sym
@@ -178,7 +178,6 @@ libvlc_media_player_set_time
 libvlc_media_player_set_title
 libvlc_media_player_set_xwindow
 libvlc_media_player_stop
-libvlc_media_player_will_play
 libvlc_media_player_navigate
 libvlc_media_player_set_video_title_display
 libvlc_media_release
diff --git a/lib/media_player.c b/lib/media_player.c
index 35640b3e85..ca65556cc3 100644
--- a/lib/media_player.c
+++ b/lib/media_player.c
@@ -1776,19 +1776,6 @@ void libvlc_media_player_previous_chapter( libvlc_media_player_t *p_mi )
     input_Release(p_input_thread);
 }
 
-int libvlc_media_player_will_play( libvlc_media_player_t *p_mi )
-{
-    input_thread_t *p_input_thread =
-                            libvlc_get_input_thread ( p_mi );
-    if ( !p_input_thread )
-        return false;
-
-    int state = var_GetInteger( p_input_thread, "state" );
-    input_Release(p_input_thread);
-
-    return state != END_S && state != ERROR_S;
-}
-
 int libvlc_media_player_set_rate( libvlc_media_player_t *p_mi, float rate )
 {
     var_SetFloat (p_mi, "rate", rate);
-- 
2.20.1



More information about the vlc-devel mailing list