[vlc-devel] [PATCH 0/4 v3] build with PDB (was tools: add pdb support to libtool)

[Steve Lhomme]

On 2019-05-20 21:31, Martin Storsjö wrote:
> On Mon, 20 May 2019, Steve Lhomme wrote:
> 
>> This new patchset gets rid of the libtool patch to put the .pdb in the 
>> .libs
>> folder. Now it's done automatically when linking.
>>
>> Steve Lhomme (4):
>>  contrib: add an option to disable generating debug information
>>  contrib: add an option to generate PDB information
>>  configure: add an option to generate PDB files when building
>>  win32: package: install generated .pdb files with package-win-common
>>
>> bin/Makefile.am                  |  3 +++
>> configure.ac                     | 13 +++++++++++++
>> contrib/bootstrap                | 12 ++++++++++++
>> contrib/src/main.mak             | 13 +++++++++++--
>> extras/package/win32/package.mak | 11 +++++++++++
>> lib/Makefile.am                  |  3 +++
>> modules/common.am                |  5 ++++-
>> src/Makefile.am                  |  3 +++
>> 8 files changed, 60 insertions(+), 3 deletions(-)
> 
> This variant looks generally good to me (modulo Rémi's comments on 1/4). 
> For patch 3/4 (which didn't come to my mailbox for some reason this 
> time, only read it on the ML archive), I think you should be able to add 
> -Wl,-pdb= in configure.ac instead of manually setting it in the 
> individual Makefile.am/common.am, no? (And common.am has got something 
> that looks like a stray change.)

Yes. I will try that.

I got rid of 1/4 as it's unnecessary.