[vlc-devel] [PATCH 2/3] configure: add an option to generate PDB files when building

Rémi Denis-Courmont remi at remlab.net
Tue May 21 10:25:16 CEST 2019


 Nit but HAVE_ is for stuff that is there, ENABLE_ is for stuff that we want to build, IIRC.

Le 21 mai 2019 11:16:32 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>This will only be enabled when building windows targets and will only
>work when
>compiling with Clang.
>---
> configure.ac | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/configure.ac b/configure.ac
>index a08be619ac..e01c065801 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -349,6 +349,19 @@ AS_IF([test "${SYS}" = "mingw32"],[
>   ])
>AC_DEFINE_UNQUOTED(VLC_WINSTORE_APP, ${vlc_winstore_app}, [Define to 1
>if you want to build for Windows Store apps])
> 
>+vlc_build_pdb=0
>+AC_ARG_ENABLE([pdb],
>+     AS_HELP_STRING([--enable-pdb],
>+                    [Build PDB files for windows targets (default
>off)]))
>+AS_IF([test "${SYS}" = "mingw32"],[
>+  AS_IF([test "${enable_pdb}" = "yes"], [
>+    vlc_build_pdb=1
>+    AX_APPEND_FLAG([-g -gcodeview],[CFLAGS])
>+    AX_APPEND_FLAG([-g -gcodeview],[CXXFLAGS])
>+    LDFLAGS="${LDFLAGS} -Wl,-pdb="
>+  ],[])
>+])
>+
> AM_CONDITIONAL([HAVE_LINUX],   [test "${SYS}" = "linux"])
> AM_CONDITIONAL([HAVE_OS2],     [test "${SYS}" = "os2"])
> 
>@@ -364,6 +377,7 @@ AM_CONDITIONAL([HAVE_WIN32],   [test "${SYS}" =
>"mingw32"])
>AM_CONDITIONAL([HAVE_WIN64],   [test "${HAVE_WIN64}" = "1"]) dnl Only
>used for the packaging
> AM_CONDITIONAL([HAVE_WINSTORE], [test "$vlc_winstore_app" = "1"])
>AM_CONDITIONAL([HAVE_WIN32_DESKTOP], [test "${SYS}" = "mingw32" -a
>"$vlc_winstore_app" = "0"])
>+AM_CONDITIONAL([HAVE_PDB],     [test "$vlc_build_pdb" = "1"])
> 
> dnl Use nasm/yasm only on x86
> AC_CHECK_PROGS(X86ASM, [nasm yasm])
>-- 
>2.17.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190521/59312131/attachment.html>


More information about the vlc-devel mailing list