[vlc-devel] [PATCH VLC3] playlist: temporize on errors

[Rémi Denis-Courmont]

Le keskiviikkona 22. toukokuuta 2019, 18.23.29 EEST Romain Vimont a écrit :
> On Wed, May 22, 2019 at 06:12:44PM +0300, Rémi Denis-Courmont wrote:
> > Le keskiviikkona 22. toukokuuta 2019, 17.13.28 EEST Romain Vimont a écrit 
:
> > > When repeat/loop is enabled, and items fail to play, VLC enters an
> > > infinite liveloop and flood errors.
> > > 
> > > We cannot just stop on errors, because retrying indefinitely may be the
> > > expected behavior:
> > > <https://trac.videolan.org/vlc/ticket/18582#comment:3>
> > > 
> > > Instead, wait some delay before starting the next item, depending on the
> > > 
> > > number of consecutive errors:
> > >  - 1st error: 100ms
> > >  - 2nd error: 200ms
> > >  - 3rd error: 400ms
> > >  - 4th error: 800ms
> > >  - 5th error: 1.6s
> > >  - further errors: 3.2s
> > > 
> > > A single successful playback resets the errors counter.
> > > 
> > > Fixes #5901 #6245 #6339 #7305 #7798 #8893 #9230 #11066 #11961 #12104
> > > 
> > >       #12909 #13878 #14679 #15805 #16697 #17660 #18582 #18942 #19284
> > >       #19313 #20365 #21564 #21672 #22118
> > 
> > This does not fix #5901. Error hell still crashes. In fact, instead of
> > just
> > making VLC barely responsive, the incomplete Qt patch series now takes the
> > whole system down into thrashing hell.
> 
> I don't understand why.

I don't know why it does that, but then again, I did not even try to figure it 
out. I can only guess that the new Qt UI fails to rate-control inbound 
dialogs.

-- 
Реми Дёни-Курмон
http://www.remlab.net/