[vlc-devel] [vlc-commits] Remove libvlc_free

[Romain Vimont]

On Wed, May 22, 2019 at 06:25:14PM +0300, Rémi Denis-Courmont wrote:
> Le keskiviikkona 22. toukokuuta 2019, 11.44.11 EEST Thomas Guillem a écrit :
> >  I don't really care about UB,
> 
> Then don't design an API for a language subject to UB.

Could you or Thomas explain to me what is undefined behavior here?

I don't understand how calling a function (libvlc_free()), which happens
to just call free(), is undefined behavior.

Anyway, IMO providing a separate "delete function" seems better, because
in the future we may need to destroy additional internal resources.

> 
> >  it was there for a reason
> 
> Yes. It was there because by the time we realized that it was useless, it was 
> already part of the stable ABI. The stable ABI that ends with 3.*.
> 
> > and it's still used.
> 
> libvlc_media_player_stop() is also still used. And?
> 
> This API is not only useless, it's misleading and thus actively harmful.
> 
> >  If you want to remove it, start a discussion on the ML.
> 
> If you want to change a past decision, you start a discussion on the ML.
> 
> I already discussed supporting CIL, and then, after realizing that it was not 
> that simple, not directly supporting it.
> 
> -- 
> レミ・デニ-クールモン
> http://www.remlab.net/
> 
> 
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel