[vlc-devel] [PATCH VLC3] playlist: temporize on errors

[Jean-Baptiste Kempf]

Yes, this is far from perfect.
But this hides/work-arounds the issue for most of our users.

Therefore, I applied this patch temporarily to 3.0 only, not master and it will be revertable, as soon as someone fixes this properly.

Best,

On Thu, May 23, 2019, at 09:06, Rémi Denis-Courmont wrote:
> Hi,
> 
> Still, this only fixes the combination of two bug, fixing neither bugs.
> 
> And then it's intrinsically racy because input item is shared data.
> 
> Le 22 mai 2019 20:09:19 GMT+03:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>> 
>> 
>> Le 22 mai 2019 18:40:57 GMT+02:00, "Rémi Denis-Courmont" <remi at remlab.net> a écrit :
>>> Le keskiviikkona 22. toukokuuta 2019, 18.32.23 EEST Romain Vimont a
>>> écrit :
>>>> On Wed, May 22, 2019 at 06:28:11PM +0300, Rémi Denis-Courmont wrote:
>>>>> Le keskiviikkona 22. toukokuuta 2019, 18.23.29 EEST Romain Vimont a
>>> écrit 
>>> :
>>>> Ah, you are talking about the new UI. This patch only targets VLC 3.
>>> Ah right, my bad. But unfortunately, in VLC 3, #5109 refers to two
>>> separate 
>>> bugs that are often but not always concomitant:
>>> 
>>> - The playlist will burn one CPU core on empty or failed items. This
>>> does not 
>>> always trigger an error.
>>> 
>>> - The Qt error dialog will steal the focus, which makes the GUI almost 
>>> unresponsive when errors keep coming in succession. This is not
>>> necessarily 
>>> caused by the playlist.
>> 
>> I don't care whether we write #5901 in the commit message or not, but IMO this patch fixes exactly the problem described: https://trac.videolan.org/vlc/ticket/5901
>> 
>>> And AFAICT, this patch really fixes neither problems, only the
>>> combination of 
>>> both.
>>> 
>>> -- 
>>> レミ・デニ-クールモン
>>> http://www.remlab.net/vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> 
> -- 
> Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté. 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

--
Jean-Baptiste Kempf - President
+33 672 704 734


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190524/62cddf10/attachment.html>