[vlc-devel] [PATCH] libvlc: use the libvlc_video_marquee_option_t enum directly

[Steve Lhomme]

It's missing the change in the actual code, but you get the idea.

On 2019-05-27 13:18, Steve Lhomme wrote:
> No need to use an unsigned if we have a clean enum.
> We already use a lot enums in all the libvlc API's.
> ---
>   include/vlc/libvlc_media_player.h | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/include/vlc/libvlc_media_player.h b/include/vlc/libvlc_media_player.h
> index 7706765beb..e34fbccf5f 100644
> --- a/include/vlc/libvlc_media_player.h
> +++ b/include/vlc/libvlc_media_player.h
> @@ -1756,19 +1756,19 @@ LIBVLC_API void libvlc_video_set_deinterlace( libvlc_media_player_t *p_mi,
>    * Get an integer marquee option value
>    *
>    * \param p_mi libvlc media player
> - * \param option marq option to get \see libvlc_video_marquee_int_option_t
> + * \param option marq option to get
>    */
>   LIBVLC_API int libvlc_video_get_marquee_int( libvlc_media_player_t *p_mi,
> -                                                 unsigned option );
> +                                             libvlc_video_marquee_option_t option );
>   
>   /**
>    * Get a string marquee option value
>    *
>    * \param p_mi libvlc media player
> - * \param option marq option to get \see libvlc_video_marquee_string_option_t
> + * \param option marq option to get
>    */
>   LIBVLC_API char *libvlc_video_get_marquee_string( libvlc_media_player_t *p_mi,
> -                                                      unsigned option );
> +                                                  libvlc_video_marquee_option_t option );
>   
>   /**
>    * Enable, disable or set an integer marquee option
> @@ -1777,21 +1777,21 @@ LIBVLC_API char *libvlc_video_get_marquee_string( libvlc_media_player_t *p_mi,
>    * or disabling (arg 0) the marq filter.
>    *
>    * \param p_mi libvlc media player
> - * \param option marq option to set \see libvlc_video_marquee_int_option_t
> + * \param option marq option to set
>    * \param i_val marq option value
>    */
>   LIBVLC_API void libvlc_video_set_marquee_int( libvlc_media_player_t *p_mi,
> -                                                  unsigned option, int i_val );
> +                                              libvlc_video_marquee_option_t option, int i_val );
>   
>   /**
>    * Set a marquee string option
>    *
>    * \param p_mi libvlc media player
> - * \param option marq option to set \see libvlc_video_marquee_string_option_t
> + * \param option marq option to set
>    * \param psz_text marq option value
>    */
>   LIBVLC_API void libvlc_video_set_marquee_string( libvlc_media_player_t *p_mi,
> -                                                     unsigned option, const char *psz_text );
> +                                                 libvlc_video_marquee_option_t option, const char *psz_text );
>   
>   /** option values for libvlc_video_{get,set}_logo_{int,string} */
>   enum libvlc_video_logo_option_t {
> -- 
> 2.17.1
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
>