[vlc-devel] [PATCH] libvlc: use the libvlc_video_marquee_option_t enum directly

[Steve Lhomme]

On 2019-05-27 16:40, Rémi Denis-Courmont wrote:
> Le maanantaina 27. toukokuuta 2019, 17.23.43 EEST Steve Lhomme a écrit :
>> On 2019-05-27 15:58, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> Are you sure that the enum is frozen in adamantium? Changing an enum
>>> typedef is an ABI break, in general.
>>
>> There's no guarantee it's going to change, just like all the other enums
>> we use. It won't change the host code after recompilation though, as
>> long as values are added after at the end of the enums.
> 
> I don't know if that's sufficient for ABI preservation in both C and C++. But
> using enum types is known to cause annoying warning problems in switch
> statement.

I think these warnings are actually useful. Unless you get with of them 
with a default: case. Then you silently ignore anything new you might 
have noticed otherwise.

> This discussion has already been had here in the past with the conclusion that
> we're better off with integers.

OK, I'll drop this one. I don't have a strong opinion about this.