[vlc-devel] [PATCH 0/7] Fixes #21997 (Impossible to get the name of modules)

Thomas Guillem thomas at gllm.fr
Mon May 27 16:45:09 CEST 2019


Hi,

cf. branch on c.v.o here: https://code.videolan.org/tguillem/vlc/tree/module-list

This patch set adds vlc_object_desc_create(): it returns a vlc object
description tree. It is used by the Qt plugin to print the tree of
object/module names. The tree is now populated within the same lock instance,
so it fixes previous race-conditions that could happen with
vlc_list_children(). There might be an (unavoidable) TOCTOU issue with the
module name. I think it's OK since this function will be only used for
debugging.

I would need your opinion for the last RFC patch (and all others).

Regards,

Thomas Guillem (7):
  objects: add back legacy list node
  objects: add vlc_object_set_module
  objects: add vlc_object_desc_create
  qt: use vlc_object_get_desc_tree
  objects: remove vlc_list_children
  objects: remove vlc_object_get_name
  RFC: set module manually when vlc_module_load is called

 include/vlc_objects.h                         |  46 +++++--
 .../qt/components/complete_preferences.cpp    |  37 ++----
 modules/gui/qt/dialogs/messages.cpp           |  50 ++++----
 modules/gui/qt/dialogs/messages.hpp           |   2 +-
 src/input/decoder_helpers.c                   |   1 +
 src/input/demux.c                             |   1 +
 src/libvlccore.sym                            |   3 +-
 src/misc/objects.c                            | 117 +++++++++++++-----
 src/misc/variables.h                          |   6 +-
 src/modules/modules.c                         |   8 +-
 src/video_output/display.c                    |   1 +
 src/video_output/opengl.c                     |   1 +
 src/video_output/window.c                     |   1 +
 13 files changed, 167 insertions(+), 107 deletions(-)

-- 
2.20.1



More information about the vlc-devel mailing list