[vlc-devel] [PATCH 03/16] Add variable to enable/disable dual subtitles

[Thomas Guillem]

On Mon, May 27, 2019, at 17:31, Roland Bewick wrote:
> 
> On 27/05/2019 2:19 PM, Thomas Guillem wrote:
> > Hello,
> >
> > This should not belong to the player.
> > I think you should store the internal dual subtitle state in each interfaces.
> 
> Hi, could you clarify what you mean?
> 
> A. Store the variable in the interface thread rather than the input 
> thread so that it's always available and both QT and hotkeys can access 
> it. (Although I'm not sure where to create the variable)

Qt and hotkey have their own interface, they don't share anything except the player/playlist, so this won't work.

> 
> B. Don't store a VLC variable at all. Hotkeys and QT interface handle it 
> separately. (If you select two subtitles using the hotkeys, you'll still 
> have to enable dual subtitles in the GUI if you want to select a 
> different secondary subtitle from there.)

Maybe. We could use some extra opinions, JB ?

> 
> Since I won't be using the VLC Player API to check whether dual 
> subtitles are enabled, I need to change how I check whether dual 
> subtitles are enabled when track selection changes in input_models.cpp.
> 
> I could add a more generic variable to the TrackListModel class 
> (something like m_allowMultipleSelection) and only enable it for 
> subtitles. This might help in fixing the bug Jean-Baptiste mentioned 
> regarding checkboxes verses radio buttons for multi/single selection.
> 
> > This does nothing if there is no input and the options will be forgotten once you play a next input.
> 
> I didn't realise it wouldn't persist. Thank you.

If we finally decide to store it in the player, you can just add a bool in vlc_player_t struct. Way simpler.


> 
> Roland
> 
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel