[vlc-devel] [PATCH] libvlc: remove misleading comment on the possible use of free()

[Rémi Denis-Courmont]

Removing two words from Doxygen won't change the fact that valid existing code relies on this.

Besides, this should return a fraction, not a string.

Le 29 mai 2019 09:19:32 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>The libvlc_free() doc already says when free() can be used (even though
>I think
>we should not advertise this possibility).
>---
> include/vlc/libvlc_media_player.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/include/vlc/libvlc_media_player.h
>b/include/vlc/libvlc_media_player.h
>index 10e302529d..2e6a747adb 100644
>--- a/include/vlc/libvlc_media_player.h
>+++ b/include/vlc/libvlc_media_player.h
>@@ -1491,7 +1491,7 @@ LIBVLC_API void libvlc_video_set_scale(
>libvlc_media_player_t *p_mi, float f_fac
>  *
>  * \param p_mi the media player
>  * \return the video aspect ratio or NULL if unspecified
>- * (the result must be released with free() or libvlc_free()).
>+ * (the result must be released with libvlc_free()).
>  */
>LIBVLC_API char *libvlc_video_get_aspect_ratio( libvlc_media_player_t
>*p_mi );
> 
>-- 
>2.17.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190529/12b36955/attachment.html>