[vlc-devel] [PATCH] logo: output in RGBA

[Rémi Denis-Courmont]

Hi,

Logo was designed, and is primarily intended for use with encoding. It uses YUVA because that's easy to blend into video.

And while it is true that vout display expect RGBA, they don't seem to agree on whether it should be premultipled or not.

Le 29 mai 2019 14:23:55 GMT+03:00, Steve Lhomme <robux4 at ycbcr.xyz> a écrit :
>That's what most display module will prefer anyway
>---
> modules/spu/logo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/modules/spu/logo.c b/modules/spu/logo.c
>index c120b503e1..0b2ddd3ca8 100644
>--- a/modules/spu/logo.c
>+++ b/modules/spu/logo.c
>@@ -380,7 +380,7 @@ static subpicture_t *FilterSub( filter_t *p_filter,
>vlc_tick_t date )
>         goto exit;
> 
>     /* Create new SPU region */
>-    video_format_Init( &fmt, VLC_CODEC_YUVA );
>+    video_format_Init( &fmt, VLC_CODEC_RGBA );
>     fmt.i_sar_num = fmt.i_sar_den = 1;
> fmt.i_width = fmt.i_visible_width = p_pic->p[Y_PLANE].i_visible_pitch;
>fmt.i_height = fmt.i_visible_height =
>p_pic->p[Y_PLANE].i_visible_lines;
>@@ -612,7 +612,7 @@ static picture_t *LoadImage( vlc_object_t *p_this,
>const char *psz_filename )
>         return NULL;
> 
>     video_format_t fmt_out;
>-    video_format_Init( &fmt_out, VLC_CODEC_YUVA );
>+    video_format_Init( &fmt_out, VLC_CODEC_RGBA );
> 
>     char *psz_url = vlc_path2uri( psz_filename, NULL );
>     picture_t *p_pic = image_ReadUrl( p_image, psz_url, &fmt_out );
>-- 
>2.17.1
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190529/8928473d/attachment.html>