[vlc-devel] [PATCH 03/16] Add variable to enable/disable dual subtitles

Thomas Guillem thomas at gllm.fr
Fri May 31 13:42:40 CEST 2019


The best solution I could think of:
 - Add an helper to get all selected track (an array like few other helpers) for an ES
 - If (selected_spu_track > 2) then SelectList else SelectOne

It will work with more than one UI used.

On Wed, May 29, 2019, at 04:47, Roland Bewick wrote:
> 
> 
> On Tue, 28 May 2019 at 5:50 PM, Roland Bewick <roland.bewick at gmail.com> wrote:
>> 
>> On 28/05/2019 5:31 PM, RĂ©mi Denis-Courmont wrote:
>>  > Hi,
>>  >
>>  > Well that's kind of the point: you can not assume that other UIs will 
>>  > understand what's happening - anyway.
>>  >
>>  > Qt can just check how many SPU are selected. But you can't assume that 
>>  > other UI will do that nor that they'll check any flag that you might 
>>  > have added.
>> 
>>  Ok, I finally understand what you're saying - thanks for clarifying.
>> 
>>  So QT can use the track selection changed event to check whether two 
>>  subtitles are simultaneously selected, and if so enable dual subtitles 
>>  in the QT GUI. (Which means some other interface enabled dual subtitles)
>> 
>>  On 28/05/2019 5:17 PM, Thomas Guillem wrote:
>> 
>>  > Maybe you could save this parameter as a variable (like 
>>  > "multiple-spus") in the root vlc object.
>> 
>>  I'm happy with this option too.
>> 
>> 
>>  In both these options I'll still have to pass the bool to TrackListModel.
>> 
>>  Roland
> 
> Could a decision be made on where I should go from here?
> 
> Thank you,
> Roland
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190531/4b4ff05c/attachment.html>


More information about the vlc-devel mailing list