[vlc-devel] [PATCH 12/20] qt: remove isRecordable getter

Thomas Guillem thomas at gllm.fr
Fri May 31 15:59:38 CEST 2019


The player is always recordable.

An access/demux is not always recordable, in that case, a sout is inserted
automatically.
---
 modules/gui/qt/components/player_controller.cpp | 1 -
 modules/gui/qt/components/player_controller.hpp | 3 ---
 2 files changed, 4 deletions(-)

diff --git a/modules/gui/qt/components/player_controller.cpp b/modules/gui/qt/components/player_controller.cpp
index 41e719ecd9..e62f0604dc 100644
--- a/modules/gui/qt/components/player_controller.cpp
+++ b/modules/gui/qt/components/player_controller.cpp
@@ -1490,7 +1490,6 @@ PRIMITIVETYPE_GETTER(VLCTick, getSubtitleDelay, m_subtitleDelay)
 PRIMITIVETYPE_GETTER(bool, isSeekable, m_capabilities & VLC_INPUT_CAPABILITIES_SEEKABLE)
 PRIMITIVETYPE_GETTER(bool, isRewindable, m_capabilities & VLC_INPUT_CAPABILITIES_REWINDABLE)
 PRIMITIVETYPE_GETTER(bool, isPausable, m_capabilities & VLC_INPUT_CAPABILITIES_PAUSEABLE)
-PRIMITIVETYPE_GETTER(bool, isRecordable, m_capabilities & VLC_INPUT_CAPABILITIES_RECORDABLE)
 PRIMITIVETYPE_GETTER(bool, isRateChangable, m_capabilities & VLC_INPUT_CAPABILITIES_CHANGE_RATE)
 PRIMITIVETYPE_GETTER(float, getSubtitleFPS, m_subtitleFPS)
 PRIMITIVETYPE_GETTER(bool, hasVideoOutput, m_hasVideo)
diff --git a/modules/gui/qt/components/player_controller.hpp b/modules/gui/qt/components/player_controller.hpp
index 2b20bcab20..46796ba054 100644
--- a/modules/gui/qt/components/player_controller.hpp
+++ b/modules/gui/qt/components/player_controller.hpp
@@ -114,7 +114,6 @@ public:
     Q_PROPERTY(bool seekable READ isSeekable NOTIFY seekableChanged)
     Q_PROPERTY(bool rewindable READ isRewindable NOTIFY rewindableChanged)
     Q_PROPERTY(bool pausable READ isPausable NOTIFY pausableChanged)
-    Q_PROPERTY(bool recordable READ isRecordable NOTIFY recordableChanged)
     Q_PROPERTY(bool ratechangable READ isRateChangable NOTIFY rateChangableChanged)
 
     //tracks
@@ -165,7 +164,6 @@ public:
     Q_PROPERTY(bool hasAudioVisualization READ hasAudioVisualization NOTIFY hasAudioVisualizationChanged)
 
     //misc
-    Q_PROPERTY(bool recording READ isRecording WRITE setRecording NOTIFY recordingChanged)
     Q_PROPERTY(ABLoopState ABloopState READ getABloopState WRITE setABloopState NOTIFY ABLoopStateChanged)
     Q_PROPERTY(VLCTick ABLoopA READ getABLoopA NOTIFY ABLoopAChanged)
     Q_PROPERTY(VLCTick ABLoopB READ getABLoopB NOTIFY ABLoopBChanged)
@@ -257,7 +255,6 @@ public slots:
     bool isSeekable() const;
     bool isRewindable() const;
     bool isPausable() const;
-    bool isRecordable() const;
     bool isRateChangable() const;
 
     //tracks
-- 
2.20.1



More information about the vlc-devel mailing list