[vlc-devel] [PATCH 03/16] Add variable to enable/disable dual subtitles

[Thomas Guillem]

On Fri, May 31, 2019, at 15:35, Roland Bewick wrote:
> 
> 
> On Fri, 31 May 2019 at 6:42 PM, Thomas Guillem <thomas at gllm.fr> wrote:
>> __
>> The best solution I could think of:
>>  - Add an helper to get all selected track (an array like few other helpers) for an ES
>>  - If (selected_spu_track > 2) then SelectList else SelectOne
>> 
>> It will work with more than one UI used.
> 
> Hi Thomas,
> 
> I don’t think this will work for the QT GUI because you can only select a secondary subtitle track if:
> 
> A. There is only one track selected (if there are two already selected, you must deselect one first)
> B. Dual subtitles are enabled
> 
> If the user selects two subtitle tracks using the hotkeys and then deselects one of them from QT, they can no longer select a second subtitle track using QT.
> 
> Thanks for your thoughts,

I think each interfaces should handle their own way to handle dual tracks.
In QT, you need a button alongside the track selection menu that will switch from radio to checkbox.
In hotkey, you add a key that switch dual/single.

In addition, you could get the initial dual state by getting the list of selected track. If count >= 2, then the user likely want dual selection

JB, any thoughts ?


> Roland
> 
>> 
>> 
>> On Wed, May 29, 2019, at 04:47, Roland Bewick wrote:
>>> 
>>> 
>>> On Tue, 28 May 2019 at 5:50 PM, Roland Bewick <roland.bewick at gmail.com> wrote:
>>>> 
>>>> On 28/05/2019 5:31 PM, Rémi Denis-Courmont wrote:
>>>> > Hi,
>>>> >
>>>> > Well that's kind of the point: you can not assume that other UIs will 
>>>> > understand what's happening - anyway.
>>>> >
>>>> > Qt can just check how many SPU are selected. But you can't assume that 
>>>> > other UI will do that nor that they'll check any flag that you might 
>>>> > have added.
>>>> 
>>>> Ok, I finally understand what you're saying - thanks for clarifying.
>>>> 
>>>> So QT can use the track selection changed event to check whether two 
>>>> subtitles are simultaneously selected, and if so enable dual subtitles 
>>>> in the QT GUI. (Which means some other interface enabled dual subtitles)
>>>> 
>>>> On 28/05/2019 5:17 PM, Thomas Guillem wrote:
>>>> 
>>>> > Maybe you could save this parameter as a variable (like 
>>>> > "multiple-spus") in the root vlc object.
>>>> 
>>>> I'm happy with this option too.
>>>> 
>>>> 
>>>> In both these options I'll still have to pass the bool to TrackListModel.
>>>> 
>>>> Roland
>>> 
>>> Could a decision be made on where I should go from here?
>>> 
>>> Thank you,
>>> Roland
>>> _______________________________________________
>>> vlc-devel mailing list
>>> To unsubscribe or modify your subscription options:
>>> https://mailman.videolan.org/listinfo/vlc-devel
>> 
>> _______________________________________________
>> vlc-devel mailing list
>> To unsubscribe or modify your subscription options:
>> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20190531/5d76573a/attachment.html>