[vlc-devel] [PATCH] libvlc: rename the aspect ratio setter/getter and use a fraction

[Rémi Denis-Courmont]

Le keskiviikkona 29. toukokuuta 2019, 17.35.37 EEST Steve Lhomme a écrit :
> >> +
> >> 
> >>   /**
> >>   
> >>    * Get current video aspect ratio.
> >>    *
> >>    * \param p_mi the media player
> >> 
> >> - * \return the video aspect ratio or NULL if unspecified
> >> + * \param out the video aspect ratio
> >> 
> >>    * (the result must be released with free() or libvlc_free()).
> >>    */
> >> 
> >> -LIBVLC_API char *libvlc_video_get_aspect_ratio( libvlc_media_player_t
> >> *p_mi );
> >> +LIBVLC_API void libvlc_video_get_sample_aspect_ratio(
> >> libvlc_media_player_t *p_mi, +
> >> 
> >>          libvlc_aspect_ratio_t *out );
> > 
> > How do you communicate unset A/R here?
> 
> denominator /**< aspect ratio denominator, 0 if the source default is
> used */

Actually, better remove the getter, I think.

-- 
Rémi Denis-Courmont
http://www.remlab.net/