[vlc-devel] [PATCH] qt:soutchain: fix compilation with Clang 9

[Jérôme Froissart]

On Mon, 4 Nov 2019, 12:54 Steve Lhomme, <robux4 at ycbcr.xyz> wrote:

> On 2019-11-04 12:42, Alexandre Janniaux wrote:
> > Hi,
> >
> > Maybe the commit message can be more explicit about what is the real
> > issue and how it is fixed. Otherwise, LGTM.
>
> Probably but I don't understand the issue. I only understand the symptom.
>

I hope my reply will be appropriate (maybe I won't explain anything you did
not know, but since I wrote this class, this mail ringed a bell for me).

It looks like QList::append( obj ) tries somewhere to assign a SoutModule
(i.e. module1 = module2), but this assignment operator has not been defined
manually (and is not generated automatically by the compiler since
assigning this way would need to re-define member objects...that have been
declared const, which is not possible by design).

Usually, the solution would be to either:
* find another method from QList that does not require the object to be
assignable.
* turn these const members as non-const
* define ourself a assignment operator (but it does not seem possible since
there are const members anyway).

I have not read the QList documentation right now, so unless we really do
*not* want SoutModule to be assignable (and I think we have no reason not
to want it), removing the 'const' like Steve did seems sensible.

Jérôme Froissart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191104/8dcab559/attachment.html>