[vlc-devel] [PATCH] qt:soutchain: fix compilation with Clang 9

[Jérôme Froissart]

Hi, both commit messages seem sensible to me.
(btw, I haven't investigated why this works with gcc. I thought assignation
of instances that have const members should never work by design,
regardless of the compiler. There might be conditional code that depends on
the compiler somewhere).
Anyway, both your messages seem fine.

Jérôme Froissart

On Mon, 4 Nov 2019, 16:02 Alexandre Janniaux, <ajanni at videolabs.io> wrote:

> Hi,
>
> For my part, if I understood the issue correctly, I would write
> something like:
>
>
> qt: soutchain: make soutchain copyable
>
> Qt requires container elements to be copyable, but class with const
> members can't be copy-assignable. Remove the const values so that we
> can copy SoutChain.
>
> This patch fix the compilation with Clang 9.
>
>
> I might have misunderstood the exact cause, but I hope it helps,
>
> Regards,
> --
> Alexandre Janniaux
> Videolabs
>
> On Mon, Nov 04, 2019 at 01:48:04PM +0100, Steve Lhomme wrote:
> > Will this do as commit log message ?
> >
> > Qt requires container elements to be copyable:
> > https://bugreports.qt.io/browse/QTBUG-54685
> > but we can't do that with const members.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191104/1c7d48d6/attachment.html>