[vlc-devel] [PATCH 11/11] decoder: make the get_device callback mandatory

Alexandre Janniaux ajanni at videolabs.io
Fri Nov 8 15:44:02 CET 2019


On Tue, Nov 05, 2019 at 04:03:16PM +0100, Steve Lhomme wrote:
> On 2019-11-05 15:40, Steve Lhomme wrote:
> > On 2019-11-05 14:56, Thomas Guillem wrote:
> > > You should add an assert then.
> >
> > This is in a header, adding asserts in headers is usually not good.
> > Also, once this test will be removed (patch pending) it will crash on
> > the following line.
> I added a vlc_assert() which is suited for VLC headers.

As long as the assert is not propagated to libvlc headers, this seem
fine to have them IMHO. We already have assert in other alike
headers if I remember correctly. vlc_assert is fine too.

Alexandre Janniaux

More information about the vlc-devel mailing list