[vlc-devel] [PATCH] test: hxxx: fix potentially uninitialized variable warnings

Alexandre Janniaux ajanni at videolabs.io
Mon Nov 11 21:40:49 CET 2019


Hi,

On 2019-11-11 17:27, Rémi Denis-Courmont wrote:
> Le maanantaina 11. marraskuuta 2019, 13.25.23 EET Alexandre Janniaux a 
> écrit :
>> Hi,
>> 
>> On Sat, Nov 09, 2019 at 08:05:25AM +0900, Rémi Denis-Courmont wrote:
>> > Yeah. This patch does not look right.
>> 
>> Ok, what does not look right? The comment?
> 
> Initialising unused values is not right.

What would you suggest? Changing the function instead
so that the values are always in a known state for the
compiler?

>> On Sat, Nov 09, 2019 at 08:05:25AM +0900, Rémi Denis-Courmont wrote:
>> > Don't confuse unitialised (a bug) with maybe unitialised (often not a
>> > bug).
>> 
>> What makes you think I'm confusing both of these?
> 
> What Steve wrote does.

I have difficulties to understand how someone else´s
writing relates to my own understanding of things.
Let's put this aside then.

Regards,
-- 
Alexandre Janniaux
Videolabs


More information about the vlc-devel mailing list