[vlc-devel] [PATCH 1/2] filter_chain: set NULL on AppendFilter output when value is implied by previous call

[Steve Lhomme]

Either because Reset() set the same input value or the we're using the same
value set by the previous AppendXXX().
---
 include/vlc_filter.h                 | 2 +-
 modules/stream_out/transcode/video.c | 2 +-
 modules/video_chroma/chain.c         | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/vlc_filter.h b/include/vlc_filter.h
index 6cc923e9d04..9a8331aee97 100644
--- a/include/vlc_filter.h
+++ b/include/vlc_filter.h
@@ -369,7 +369,7 @@ VLC_API void filter_chain_Clear(filter_chain_t *);
  *
  * \param chain filter chain to append a filter to
  * \param name filter name
- * \param fmt_out filter output format
+ * \param fmt_out forced output format or NULL for the default chain output
  * \return a pointer to the filter or NULL on error
  */
 VLC_API filter_t *filter_chain_AppendFilter(filter_chain_t *chain,
diff --git a/modules/stream_out/transcode/video.c b/modules/stream_out/transcode/video.c
index 1853fc6c52d..b1754ca23ac 100644
--- a/modules/stream_out/transcode/video.c
+++ b/modules/stream_out/transcode/video.c
@@ -327,7 +327,7 @@ static int transcode_video_filters_init( sout_stream_t *p_stream,
         filter_chain_AppendFilter( id->p_f_chain,
                                    p_cfg->video.psz_deinterlace,
                                    p_cfg->video.p_deinterlace_cfg,
-                                   p_src );
+                                   NULL );
         p_src = filter_chain_GetFmtOut( id->p_f_chain );
     }
 
diff --git a/modules/video_chroma/chain.c b/modules/video_chroma/chain.c
index ab523397a2e..c4364e8ab7e 100644
--- a/modules/video_chroma/chain.c
+++ b/modules/video_chroma/chain.c
@@ -395,7 +395,7 @@ static int BuildFilterChain( filter_t *p_filter )
             p_sys->p_video_filter =
                 filter_chain_AppendFilter( p_sys->p_chain,
                                            p_filter->psz_name, p_filter->p_cfg,
-                                           &fmt_mid );
+                                           NULL );
             if( p_sys->p_video_filter )
             {
                 filter_AddProxyCallbacks( p_filter,
-- 
2.17.1