[vlc-devel] [PATCH] contrib: ffmpeg: remove gas-preprocessor on Android

Marvin Scholz epirat07 at gmail.com
Mon Nov 18 12:43:02 CET 2019


LGTM

On 15 Nov 2019, at 6:11, zhilizhao wrote:

> Ping for review, thanks!
>
>> On Nov 10, 2019, at 10:47 PM, Zhao Zhili <quinkblack at foxmail.com> wrote:
>>
>> Build vlc-android on macOS was broken since gas-preprocessor fix_unreq
>> is enabled by default on macOS.
>> ---
>> contrib/src/ffmpeg/rules.mak | 5 -----
>> 1 file changed, 5 deletions(-)
>>
>> diff --git a/contrib/src/ffmpeg/rules.mak b/contrib/src/ffmpeg/rules.mak
>> index 1ba04616e5..1d34ba6bdf 100644
>> --- a/contrib/src/ffmpeg/rules.mak
>> +++ b/contrib/src/ffmpeg/rules.mak
>> @@ -170,11 +170,6 @@ endif
>> ifeq ($(ANDROID_ABI), x86_64)
>> FFMPEGCONF +=  --disable-mmx --disable-mmxext --disable-inline-asm
>> endif
>> -ifdef HAVE_NEON
>> -ifeq ($(ANDROID_ABI), armeabi-v7a)
>> -FFMPEGCONF += --as='gas-preprocessor.pl -as-type clang -arch arm $(CC)'
>> -endif
>> -endif
>> endif
>>
>> # Windows
>> -- 
>> 2.21.0
>>
>
>
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel


More information about the vlc-devel mailing list