[vlc-devel] [PATCH 00/10] qml: fix player menu and key handling

Pierre Lamot pierre at videolabs.io
Mon Nov 18 18:14:03 CET 2019


the main points of this patchset are:

 - key event matching factorization
 - fix events being handled twice in the player
 - bugs fixes in the player menu (focus loss, no entry selected, ...)

Pierre Lamot (10):
  qt: expose count in Track, Title, Chapter and Program models
  qt: add js files to qmlcachegen preprocessor
  qml: factorize navigation key matching
  qml: set the initial selected entry in player menu
  qml: fix focus loss within player menu on title change
  qml: fix Escape key event being handled twice in player menu
  qml: add defaultKeyReleaseAction to NavigableFocusScope
  qml: factorize key handling in the Player
  qml: fix space event being handled twice while muting volume widget
  qml: remove obsolete TrackSelector and ModalControlBar

 modules/gui/qt/Makefile.am                    |   9 +-
 modules/gui/qt/qml/about/About.qml            |   3 +-
 .../gui/qt/qml/mediacenter/MCMainDisplay.qml  |   3 +-
 modules/gui/qt/qml/player/ControlButtons.qml  |  11 ++
 modules/gui/qt/qml/player/MiniPlayer.qml      |   5 +-
 modules/gui/qt/qml/player/ModalControlBar.qml |  67 ----------
 modules/gui/qt/qml/player/Player.qml          |  72 +++++-----
 modules/gui/qt/qml/player/PlayerMenu.qml      |  10 ++
 modules/gui/qt/qml/player/PlayerMenuItem.qml  |   9 ++
 modules/gui/qt/qml/player/TrackSelector.qml   | 125 ------------------
 modules/gui/qt/qml/player/VolumeWidget.qml    |  11 +-
 modules/gui/qt/qml/utils/ExpandGridView.qml   |  15 ++-
 modules/gui/qt/qml/utils/KeyHelper.js         |  64 +++++++++
 .../gui/qt/qml/utils/KeyNavigableGridView.qml |  15 ++-
 .../gui/qt/qml/utils/KeyNavigableListView.qml |  19 +--
 .../gui/qt/qml/utils/NavigableFocusScope.qml  |  25 +++-
 modules/gui/qt/util/input_models.cpp          |   6 +
 modules/gui/qt/util/input_models.hpp          |  29 ++++
 modules/gui/qt/vlc.qrc                        |   3 +-
 19 files changed, 231 insertions(+), 270 deletions(-)
 delete mode 100644 modules/gui/qt/qml/player/ModalControlBar.qml
 delete mode 100644 modules/gui/qt/qml/player/TrackSelector.qml
 create mode 100644 modules/gui/qt/qml/utils/KeyHelper.js

--
2.17.1


More information about the vlc-devel mailing list