[vlc-devel] [PATCH 07/10] vdpau: store the xcb_connection_t in the vdpau_decoder_device_t

Steve Lhomme robux4 at ycbcr.xyz
Mon Nov 25 10:27:45 CET 2019

On 2019-11-23 11:12, RĂ©mi Denis-Courmont wrote:
> Hi,
> There should not be an XCB connection there in the first place. We already have
> too many connections to the X server, and they're a very limited resource.

In push model the vdp_t is provided to the VDPAU display module. It 
should match the vdp_t that is currently created.

I removed some code where the chroma filter was doing some conversion 
between mismatching vdp_t:
/* Corner case: different VDPAU instances decoding and rendering */

Maybe this corner case can be handled internally in the display module, 
as all other module will use whatever vdp_t they are given, regardless 
of the screen. In this case the display module does the connection it 
needs and will need to check if it matches the decoder device it gets.

More information about the vlc-devel mailing list