[vlc-devel] [PATCH v5 7/7] upnp: Add UPnP/DLNA MediaRenderer control plugin

[Rémi Denis-Courmont]

Hi,

1 should map to one and 0 should map to zero. The mapping between zero and one need not be the identity. It depends if/how UPnP defines the scale. Though it obviously must be continuous and monotonic.

I really don't think there should be a magic amplification factor. That would be very confusing and potentially very damaging for audio quality as well due to saturation.

Le 26 novembre 2019 03:06:24 GMT+02:00, Alexandre Janniaux <ajanni at videolabs.io> a écrit :
>Hi,
>
>On Mon, Nov 25, 2019 at 10:24:56PM +0100, Johan Gunnarsson wrote:
>> > VLC should be able to handle volumes above 100. I suppose in UPNP
>0-100
>> > is the regular range. 100 should match the 1.0 value in VLC.
>Otherwise
>> > everything will likely play at half the volume if most UPNP clients
>> > request 100.
>> >
>> > Same comment for all the volume related calls/callbacks.
>>
>> Currently UPnP 0 (quietest) maps to VLC 0.0 and UPnP 100 (loudest)
>> maps to VLC 2.0. I think this is correct. If a UPnP client request
>100
>> it will get full volume.
>
>I don't know if it is that easy. 2.0 is an overdrive of the
>volume, it's more that loudest, and the volume_set callback
>in audio_output mentions that 1.f is the nominal value, not
>really 2.f.
>
>https://www.videolan.org/developers/vlc/doc/doxygen/html/structaudio__output.html#a38d3e01f0ae4d0a266510a7321b3a9f2
>
>Maybe you could allow overdrive through a configuration
>variable (like qt-max-volume) but I don't think it's correct
>to do software gain at 100% of volume from a user point of
>view.
>
>Regards,
>--
>Alexandre Janniaux
>Videolabs
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191126/848a4bb3/attachment.html>