[vlc-devel] [PATCH 07/10] vdpau: store the xcb_connection_t in the vdpau_decoder_device_t

[Steve Lhomme]

On 2019-11-25 20:00, Rémi Denis-Courmont wrote:
> Le maanantaina 25. marraskuuta 2019, 11.27.45 EET Steve Lhomme a écrit :
>> On 2019-11-23 11:12, Rémi Denis-Courmont wrote:
>>> Hi,
>>>
>>> There should not be an XCB connection there in the first place. We already
>>> have too many connections to the X server, and they're a very limited
>>> resource.
>> In push model the vdp_t is provided to the VDPAU display module.
> 
> Yes - and that in no way justifies adding yet another connection to the X11
> server.
> 
>> I removed some code where the chroma filter was doing some conversion
>> between mismatching vdp_t:
>> /* Corner case: different VDPAU instances decoding and rendering */
>>
>> Maybe this corner case can be handled internally in the display module,
> 
> The corner case is impossible in push model. The display and the decoder will
> use the same VDPAU instance from the same VLC decoder device: the chroma filter
> will just pass the VDPAU instance from the decoder to the display, thus
> ensuring that they match, instead of comparing them.

OK, then it makes things a lot easier