[vlc-devel] [PATCH v5 7/7] upnp: Add UPnP/DLNA MediaRenderer control plugin

[Alexandre Janniaux]

Hi,

On Tue, Nov 26, 2019 at 12:37:57PM +0100, Johan Gunnarsson wrote:
> IIRC UPnP doesn't define the scale except 0 means quiet and each step in
> positive direction should make it louder. I can change so UPnP 100 maps to
> VLC 1.0 if that's what you guys want.

Thank you for your change !

> On Tue, 26 Nov 2019, 09:29 Rémi Denis-Courmont, <remi at remlab.net> wrote:
> > I really don't think there should be a magic amplification factor. That
> > would be very confusing and potentially very damaging for audio quality as
> > well due to saturation.

By default, I completely agree with you.

For the customization part, some users might want to add
audio gain to the audio_output, like for the current use
case of audio gain in normal playback.

This gain would be better handled by changing the scale so
that we don't trigger audio boost if the user doesn't need
it to reach the current volume level set, instead of just
having an audio boost filter always running in the current
pipeline.

I agree that it's not ideal to have a scale going greater
than 1.0 but a refactor changing the normal playback would
also change this behaviour too anyway.

Regards,
--
Alexandre Janniaux
Videolabs