[vlc-devel] [vlc-commits] skins2: ensure playlist gets stopped before terminating vlc.

Rémi Denis-Courmont remi at remlab.net
Fri Nov 29 20:09:01 CET 2019


Le perjantaina 29. marraskuuta 2019, 20.43.29 EET Erwan Tulou a écrit :
> vlc | branch: master | Erwan Tulou <erwan10 at videolan.org> | Fri Nov 29
> 19:32:25 2019 +0100| [0594abc06cb1a57548a7c3bf977e3071e64ef022] |
> committer: Erwan Tulou
> 
> skins2: ensure playlist gets stopped before terminating vlc.
> 
> > http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0594abc06cb1a57548a
> > 7c3bf977e3071e64ef022
> ---
> 
>  modules/gui/skins2/src/skin_main.cpp | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/modules/gui/skins2/src/skin_main.cpp
> b/modules/gui/skins2/src/skin_main.cpp index 087dd82cc0..d52e904d8d 100644
> --- a/modules/gui/skins2/src/skin_main.cpp
> +++ b/modules/gui/skins2/src/skin_main.cpp
> @@ -143,6 +143,12 @@ static void Close( vlc_object_t *p_this )
> 
>      msg_Dbg( p_intf, "closing skins2 module" );
> 
> +    // ensure the playlist is stopped
> +    vlc_playlist_t *playlist = vlc_intf_GetMainPlaylist( p_intf );
> +    vlc_playlist_Lock( playlist );
> +    vlc_playlist_Stop ( playlist );
> +    vlc_playlist_Unlock( playlist );

This does not guarantee that the playlist is stopped, only that it was stopped 
until the Unlock. This whole patch does not make sense to me.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/





More information about the vlc-devel mailing list