[vlc-devel] [PATCH] test: run_vlc.sh: Don't override existing ASAN_OPTIONS

[Sean McGovern]

OK, then LGTM.

-- Sean McGovern



  Original Message  


From: hugo at beauzee.fr
Sent: November 29, 2019 11:20 AM
To: vlc-devel at videolan.org
Reply-to: vlc-devel at videolan.org
Subject: Re: [vlc-devel] [PATCH] test: run_vlc.sh: Don't override existing ASAN_OPTIONS


Hi,

As far as I can see, it is!

Regards,

On Fri, Nov 29, 2019, at 5:07 PM, Sean McGovern wrote:
> Hi Hugo,
>
> In the case where ASAN_OPTIONS is indeed empty, is it OK for that
> string to start with a comma?
>
> -- Sean McGovern
>
>
>
>   Original Message  
>
>
> From: hugo at beauzee.fr
> Sent: November 29, 2019 10:35 AM
> To: vlc-devel at videolan.org
> Reply-to: vlc-devel at videolan.org
> Subject: [vlc-devel] [PATCH] test: run_vlc.sh: Don't override existing
> ASAN_OPTIONS
>
>
> ---
> test/run_vlc.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/run_vlc.sh b/test/run_vlc.sh
> index 5a784460bd..6edf4333c8 100755
> --- a/test/run_vlc.sh
> +++ b/test/run_vlc.sh
> @@ -9,7 +9,7 @@ $VLC -Idummy vlc://quit
> $VLC -vv -Irc,oldrc vlc://quit
> $VLC -vv -Irc,oldrc --play-and-exit vlc://nop
>
> -ASAN_OPTIONS="detect_leaks=0"
> +ASAN_OPTIONS="$ASAN_OPTIONS,detect_leaks=0"
> export ASAN_OPTIONS
>
> $VLC --play-and-exit vlc://nop
> --
> 2.20.1
>
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel
> _______________________________________________
> vlc-devel mailing list
> To unsubscribe or modify your subscription options:
> https://mailman.videolan.org/listinfo/vlc-devel

--
  Hugo Beauzée-Luyssen
  hugo at beauzee.fr
_______________________________________________
vlc-devel mailing list
To unsubscribe or modify your subscription options:
https://mailman.videolan.org/listinfo/vlc-devel