[vlc-devel] [PATCH] Qt: initialize m_fullscreen

[erwan.tulou at gmail.com]

Hi,

On 29/11/2019 20:39, Rémi Denis-Courmont wrote:
> Le perjantaina 29. marraskuuta 2019, 2.17.57 EET erwan.tulou at gmail.com a écrit
> :
>> Hi,
>>
>>      Another patch to help clean up menu issues with vlc.
>>
>>      This patch ensures that, when launching a video with 'vlc
>> --fullscreen', the PopupMenu will be correct (in synch with the vlc player)
>>
>> Rgds
>> Erwan
> This looks race-prone to me.
>
Do you mean the lock on the player should be used ? The documentation 
states that a call to this function doesn't need to be locked. Or is 
there something else that I failed to see ?

Just one thing, a listener is installed prior to getting the value. But, 
the initial state is not given. we still need to get it manually.