[vlc-devel] [PATCH] configure: fail on casting incompatible pointers

[Rémi Denis-Courmont]

Next people will add incorrect manual casts to silence the errors instead of fixing them properly. Not a good idea.

Le 2 octobre 2019 13:14:14 GMT+03:00, Romain Vimont <rom1v at videolabs.io> a écrit :
>---
> configure.ac | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/configure.ac b/configure.ac
>index 210b4ca537..2fa70daf22 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -988,7 +988,7 @@ dnl
>AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef
>-Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security
>-Wduplicated-branches -Wduplicated-cond], [CFLAGS])
>AX_APPEND_COMPILE_FLAGS([-Wall -Wextra -Wsign-compare -Wundef
>-Wpointer-arith -Wvolatile-register-var -Wformat -Wformat-security
>-Wduplicated-branches -Wduplicated-cond], [CXXFLAGS])
> 
>-AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings
>-Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self
>-Wlogical-op -Wshadow=local -Wmultistatement-macros], [CFLAGS])
>+AX_APPEND_COMPILE_FLAGS([-Wbad-function-cast -Wwrite-strings
>-Wmissing-prototypes -Werror-implicit-function-declaration -Winit-self
>-Wlogical-op -Wshadow=local -Wmultistatement-macros
>-Werror=incompatible-pointer-types], [CFLAGS])
> AX_APPEND_COMPILE_FLAGS([-pipe], [CFLAGS])
> 
> dnl
>-- 
>2.23.0
>
>_______________________________________________
>vlc-devel mailing list
>To unsubscribe or modify your subscription options:
>https://mailman.videolan.org/listinfo/vlc-devel

-- 
Envoyé de mon appareil Android avec Courriel K-9 Mail. Veuillez excuser ma brièveté.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mailman.videolan.org/pipermail/vlc-devel/attachments/20191002/2f506e61/attachment.html>