[vlc-devel] [PATCH] configure: fail on casting incompatible pointers

[Steve Lhomme]

On 2019-10-02 14:55, Denis Charmet wrote:
> On 2019-10-02 14:43, Steve Lhomme wrote:
>> On 2019-10-02 14:37, Denis Charmet wrote:
>>> I agree with Rémi here, using it on a small code base is good, using 
>>> it in something as huge as VLC is more a hassle than anything else 
>>> especially when you work on embedded platform with crazy broken 
>>> toolchains.
>>
>> Except we do not have any contribs with this issue, as I said I've
>> been using it for month and it helped a lot.
> 
> I'm talking about other people building it with stupid toolchains not 
> devs on their up to date computer.
> 
> 
>>> And in the end you still have the warning to spot the errors.
>>
>> Just like the commit that was pushed yesterday with a warning.
>>
>> Warnings are precisely useless because we have a huge codebase. When
>> building VLC there's way too much noise to actually see the good ones.
> 
> Then enforce it on CI not on the general configure.ac. It's good when 
> you control all the build parameters but it's not the case for VLC. With 
> this you end up with people just not using VLC because they can't be 
> bothered to remove flags in autotools.

Yeah, that's another option. That's what I'm using anyway:

${SCRIPT_PATH}/configure.sh --host=$TRIPLET 
--with-contrib=../contrib/$TRIPLET $CONFIGFLAGS \
     CFLAGS="$CFLAGS -Werror=invalid-command-line-argument 
-Werror=incompatible-pointer-types -Werror=missing-field-initializers" \
     CXXFLAGS="$CXXFLAGS -Werror=invalid-command-line-argument 
-Werror=incompatible-pointer-types -Werror=missing-field-initializers"


This can be added to the build script, and later in Gitlab.