[vlc-devel] [PATCH] configure: fail on casting incompatible pointers

[Sebastian Ramacher]

On 2019-10-02 21:05:05, Rémi Denis-Courmont wrote:
> Le keskiviikkona 2. lokakuuta 2019, 17.12.26 EEST Denis Charmet a écrit :
> > On 2019-10-02 15:38, Steve Lhomme wrote:
> > > That could be nice. Also there's no build script for Linux, so most
> > > Linux devs won't have them by default. So I'd vote to have the flag
> > > enabled by default.
> > 
> > You mean disabled :)
> > IMNSHO,-Werror should never be enabled by default on any widely used
> > projects.
> 
> Exactly. Exactly what was said by many people the previous times too.
> 
> We only have one warning as error, for missing declarations, because that's 
> really almost always triggering a run-time bug: it really caused a major 
> issues on 64-bits platforms way back when devs used almost exclusively 32-bits 
> day to day.

Agreed. Please don't enable it per default. This just causes unnecessary
work for packagers when builds suddenly break for no good reason.

Cheers
-- 
Sebastian Ramacher