[vlc-devel] [PATCH 0/9] Handle (AC-3 core + EAC3 Ext) -> AC3 fallback

[Rémi Denis-Courmont]

Le torstaina 3. lokakuuta 2019, 19.51.17 EEST Jean-Baptiste Kempf a écrit :
> On Thu, Oct 3, 2019, at 18:21, Thomas Guillem wrote:
> > On Thu, Oct 3, 2019, at 17:38, Rémi Denis-Courmont wrote:
> > > Le torstaina 3. lokakuuta 2019, 17.33.50 EEST Thomas Guillem a écrit :
> > > > Hello,
> > > > 
> > > > cf. my gitlab branch here:
> > > > https://code.videolan.org/tguillem/vlc/tree/eac3-fix/2
> > > > 
> > > > The EAC3 codec can be packetized in two different ways. Bluray Discs
> > > > use an
> > > > AC-3 Core + an EAC3 Extension whereas the broadcast world use
> > > > indivisible
> > > > EAC3 streams.
> > > 
> > > Since this needs ad-hoc handling anyway, you would presumably be better
> > > off
> > > with a third codec ID than with yet another codec parameter.
> > 
> > Also OK with that, but we need 2 new codec ID. DTSHD and A52_EXT
> 
> A52_EXT is not a codec. EAC3 is.
> 
> I understand the need for DTSHD, but not for A52_EXT. Can you use the
> profile?

There's no profile in audio format.

I don't know and I don't care if A/52 with extension is a codec or is not. It 
is a different audio format than A/52 core-only. You cannot send the earlier 
over S/PDIF / write it to an audio output plugin expecting A/52.

So either it gets a different format, or the existing parameters are adjusted 
to match the higher bit rate. But the later option seems a lot more error-
prone to me.

-- 
レミ・デニ-クールモン
http://www.remlab.net/